#1287 PHP Language Server #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registers a language server for the PHP editor. Signed-off-by: Kaloyan Raev <[email protected]>
|
Can one of the admins verify this patch? |
26 tasks
|
@evidolob please review |
|
LGTM, @tolusha ? |
|
LGTM |
|
Binaries are uploaded. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Registers a language server for the PHP editor.
The PHP Crane project is used for the language server: https://github.com/HvyIndustries/crane
The remote agent registry on https://codenvy.com/update/repository/ must be updated in the following way:
agent.jsonfile must be served on https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.phpAttachment: agent.json.zip
vscode-crane-server.tar.gzfile must be served on https://codenvy.com/update/repository/public/download/org.eclipse.che.ls.php.binariesAttachment: vscode-crane-server.tar.gz
What issues does this PR fix or reference?
This PR is in relation to #1287.
New behavior
Language server capabilities for PHP.
PR type
Minor change checklist
Signed-off-by: Kaloyan Raev [email protected]