-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Language Server Protocol #2452
Conversation
…age server protocol. It is based on the java binding from https://github.com/TypeFox/ls-api. Signed-off-by: Sven Efftinge <[email protected]>
… and ‘textDocument/publishDiagnostics’ The ‘publishDiagnostics’ is a server-side notification, which are sent back to the client via WebSocket.
Initial prototype of language server protocol extension for Che
…he into language-server # Conflicts: # plugins/pom.xml
Signed-off-by: Sven Efftinge <[email protected]>
[lsp] added setter methods to DTOs
…les and runs them, if they are of the form ‘fileextension-languageserver.jar’ Signed-off-by: Sven Efftinge <[email protected]>
Signed-off-by: Sven Efftinge <[email protected]>
Signed-off-by: Sven Efftinge <[email protected]>
Language server
Signed-off-by: Sven Efftinge <[email protected]>
…onfiguration for Orion editor. Signed-off-by: Sven Efftinge <[email protected]>
…ile types, mime types and highlighting config.
… kind, shows documentation from CompletionItem
…he into language-server
…he into language-server
…he into language-server
#1287 PHP Language Server
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/402/ |
import java.util.LinkedList; | ||
import java.util.List; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc
@@ -159,6 +163,7 @@ private void startWsAgentComponents(final Iterator<Provider<WsAgentComponent>> c | |||
component.start(new Callback<WsAgentComponent, Exception>() { | |||
@Override | |||
public void onSuccess(WsAgentComponent result) { | |||
Log.error(component.getClass(), result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like debug output
import org.eclipse.che.ide.api.component.WsAgentComponent; | ||
import org.eclipse.che.ide.statepersistance.AppStateManager; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evidolob javadoc
* @author Evgen Vidolob | ||
*/ | ||
public class Throttler { | ||
// private Promise activePromise; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evidolob check please this comment code
@@ -0,0 +1,81 @@ | |||
package org.eclipse.che.plugin.languageserver.ide.editor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license
|
||
appContext.getWorkspaceRoot().getFile(filePath).then(openNode(selectionRange)); | ||
|
||
// .then(new Operation<Optional<File>>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
public class DtoConverter { | ||
|
||
public static InitializeResultDTO asDto(InitializeResult initializeResult) { | ||
// List<LanguageDescriptionDTO> languageDescriptionDTOs = initializeResult.getSupportedLanguages() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
synchronized (launcher) { | ||
LanguageServer server = languageIdToServers.get(languageId); | ||
if (server != null) { | ||
// LanguageServerDescription initializeResult = serversToInitResult.get(server); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment code
|
||
@Singleton | ||
@Path("languageserver") | ||
public class LanguageRegistryService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javadoc
@@ -0,0 +1,143 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this is good location for those scripts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary solution until conception of AgentRegistry is done.
Build # 406 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/406/ to view the results. |
ok |
What does this PR do?
Implemented features
Base issue: #1287
New behavior
Support Language Server protocol
Please review Che's Contributing Guide for best practices.