Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3669] Fix deletion of obsolete metrics in KafkaConsumer. #3672

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[#3669] Fix deletion of obsolete metrics in KafkaConsumer. #3672

merged 1 commit into from
Dec 10, 2024

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Dec 8, 2024

This fixes #3669 .

@calohmn calohmn added bug C&C Command and Control labels Dec 8, 2024
@calohmn calohmn requested a review from sophokles73 as a code owner December 8, 2024 11:07
sophokles73
sophokles73 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit 43b8466 into eclipse-hono:master Dec 10, 2024
7 checks passed
@calohmn calohmn deleted the PR/fix_consumer_obsolete_metrics_removal branch December 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophokles73 sophokles73 sophokles73 approved these changes

Assignees
No one assigned
Labels
bug C&C Command and Control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deletion of Kafka consumer metrics for deleted topics doesn't work any more
2 participants
@calohmn @sophokles73