Skip to content

Commit

Permalink
iox-#2044 Fix typos and copy&paste errors
Browse files Browse the repository at this point in the history
  • Loading branch information
elBoberido committed Oct 25, 2023
1 parent 66d544d commit 17657f4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ FixedPositionContainer<T, CAPACITY>::emplace(Targs&&... args) noexcept
// +---+---+---+---+---+---+ - +
// | 3 | 2 | 5 | 4 | I | I | | <- next index with same status
// +---+---+---+---+---+---+ - +
// before insertion
// after insertion
// begin_used
// |
// | begin_free
Expand Down Expand Up @@ -294,7 +294,7 @@ FixedPositionContainer<T, CAPACITY>::erase(const IndexType index) noexcept
// +---+---+---+---+---+---+ - +
// | 2 | 3 | 5 | 4 | I | I | | <- next index with same status
// +---+---+---+---+---+---+ - +
// before removal
// after removal
// begin_free
// |
// | begin_used
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ namespace iox
/// inserting or removing elements does not change their positions. The container is optimized for efficient iteration
/// over the elements by always having the 'next' index point to the closest element in memory, which prevents
/// unnecessary back-and-forth jumps.
/// @param T is the type the container holds
/// @param Capacity is the maximum number of elements the container can hold
/// @tparam T is the type the container holds
/// @tparam CAPACITY is the maximum number of elements the container can hold
template <typename T, uint64_t CAPACITY>
class FixedPositionContainer final
{
Expand Down Expand Up @@ -65,7 +65,6 @@ class FixedPositionContainer final
FixedPositionContainer() noexcept;
~FixedPositionContainer() noexcept;

/// @todo iox-#2052 create an issue to implement copy/move ctors and assignment operators
FixedPositionContainer(const FixedPositionContainer&) noexcept = delete;
FixedPositionContainer(FixedPositionContainer&&) noexcept = delete;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ TEST_F(FixedPositionContainer_test, FillingUpAndErasingAgainInReverseOrderResult
TEST_F(FixedPositionContainer_test, NewlyCreatedContainerIsNotFull)
{
::testing::Test::RecordProperty("TEST_ID", "69f3e641-3356-4c52-ae3e-fcca4811e329");
EXPECT_THAT(sut.empty(), Eq(true));
EXPECT_THAT(sut.full(), Eq(false));
}

TEST_F(FixedPositionContainer_test, AddingOneElementResultsInNonFullContainer)
Expand Down

0 comments on commit 17657f4

Please sign in to comment.