removed IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS made IOX_MAX_NUMBER_OF_N…

…OTIFIERS configurable again
eclipse-iceoryx · Nov 13, 2023 · 461b96d · 461b96d
1 parent 443a0d8
commit 461b96d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/iceoryx_posh/BUILD.bazel b/iceoryx_posh/BUILD.bazel
@@ -29,7 +29,7 @@ configure_file(
         # FIXME: for values see "iceoryx_posh/cmake/IceoryxPoshDeployment.cmake" ... for now some nice defaults
         "@platforms//os:macos": {
             "IOX_COMMUNICATION_POLICY": "ManyToManyPolicy",
-            "IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS": "256",
+            "IOX_MAX_NUMBER_OF_NOTIFIERS": "256",
             "IOX_MAX_CHUNKS_ALLOCATED_PER_PUBLISHER_SIMULTANEOUSLY": "8",
             "IOX_MAX_CHUNKS_HELD_PER_SUBSCRIBER_SIMULTANEOUSLY": "256",
             "IOX_MAX_CLIENTS_PER_SERVER": "256",
@@ -53,7 +53,7 @@ configure_file(
         },
         "//conditions:default": {
             "IOX_COMMUNICATION_POLICY": "ManyToManyPolicy",
-            "IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS": "256",
+            "IOX_MAX_NUMBER_OF_NOTIFIERS": "256",
             "IOX_MAX_CHUNKS_ALLOCATED_PER_PUBLISHER_SIMULTANEOUSLY": "8",
             "IOX_MAX_CHUNKS_HELD_PER_SUBSCRIBER_SIMULTANEOUSLY": "256",
             "IOX_MAX_CLIENTS_PER_SERVER": "256",

diff --git a/iceoryx_posh/cmake/IceoryxPoshDeployment.cmake b/iceoryx_posh/cmake/IceoryxPoshDeployment.cmake
@@ -127,14 +127,10 @@ configure_option(
     NAME IOX_MAX_CLIENTS_PER_SERVER
     DEFAULT_VALUE 256
 )
-
-# note: don't change IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS value because it could break the C-Binding
-#configure_option(
-#    NAME IOX_MAX_NUMBER_OF_NOTIFIERS
-#    DEFAULT_VALUE 256
-#)
-set(IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS 256)
-
+configure_option(
+    NAME IOX_MAX_NUMBER_OF_NOTIFIERS
+    DEFAULT_VALUE 256
+)
 
 message(STATUS "[i] <<<<<<<<<<<<<< End iceoryx_posh configuration: >>>>>>>>>>>>>>")
 
diff --git a/iceoryx_posh/cmake/iceoryx_posh_deployment.hpp.in b/iceoryx_posh/cmake/iceoryx_posh_deployment.hpp.in
@@ -46,7 +46,7 @@ constexpr uint32_t IOX_MAX_CHUNKS_ALLOCATED_PER_PUBLISHER_SIMULTANEOUSLY =
 constexpr uint64_t IOX_MAX_PUBLISHER_HISTORY = static_cast<uint32_t>(@IOX_MAX_PUBLISHER_HISTORY@);
 constexpr uint32_t IOX_MAX_CHUNKS_HELD_PER_SUBSCRIBER_SIMULTANEOUSLY =
     static_cast<uint32_t>(@IOX_MAX_CHUNKS_HELD_PER_SUBSCRIBER_SIMULTANEOUSLY@);
- constexpr uint32_t IOX_MAX_NUMBER_OF_NOTIFIERS = static_cast<uint32_t>(@IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS@);
+ constexpr uint32_t IOX_MAX_NUMBER_OF_NOTIFIERS = static_cast<uint32_t>(@IOX_MAX_NUMBER_OF_NOTIFIERS@);
  constexpr uint32_t IOX_MAX_PROCESS_NUMBER = static_cast<uint32_t>(@IOX_MAX_PROCESS_NUMBER@);
  constexpr uint32_t IOX_MAX_NODE_NUMBER = static_cast<uint32_t>(@IOX_MAX_NODE_NUMBER@);
  constexpr uint32_t IOX_MAX_NODE_PER_PROCESS = static_cast<uint32_t>(@IOX_MAX_NODE_PER_PROCESS@);