Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1755 flush testing logger on terminate #1831

Merged
merged 4 commits into from
Apr 18, 2023
Merged

iox-#1755 flush testing logger on terminate #1831

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c85949
iox-#1755 Flush TestingLogger on terminate
elBoberido Nov 14, 2022
5f7ec04
iox-#1755 Flush TestingLogger on SIGSEGV
elBoberido Dec 19, 2022
436db65
iox-#1755 Exclude Windows and catch SIGFPE
elBoberido Apr 3, 2023
4523a08
iox-#1755 Rename sigHandler function
elBoberido Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 50 additions & 4 deletions iceoryx_hoofs/testing/testing_logger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@

#include <iostream>

#include <csignal>
#include <cstdio>
#include <cstring>

// NOLINTNEXTLINE(hicpp-deprecated-headers) required to work on some platforms
#include <setjmp.h>

namespace iox
{
namespace testing
Expand Down Expand Up @@ -112,15 +119,54 @@ std::vector<std::string> TestingLogger::getLogMessages() noexcept
return logger.m_loggerData->buffer;
}

#if !defined(_WIN32)
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables) global variable is required as jmp target
jmp_buf exitJmpBuffer;

static void sigHandler(int sig, siginfo_t*, void*)
{
switch (sig)
{
case SIGSEGV:
std::cout << "SIGSEGV\n" << std::flush;
break;
case SIGFPE:
std::cout << "SIGFPE\n" << std::flush;
break;
default:
std::cout << "signal: " << sig << "\n" << std::flush;
break;
}
dynamic_cast<TestingLogger&>(log::Logger::get()).printLogBuffer();

constexpr int JMP_VALUE{1};
// NOLINTNEXTLINE(cert-err52-cpp) exception cannot be used and longjmp/setjmp is a working fallback
longjmp(&exitJmpBuffer[0], JMP_VALUE);
}
#endif

void LogPrinter::OnTestStart(const ::testing::TestInfo&)
{
dynamic_cast<TestingLogger&>(log::Logger::get()).clearLogBuffer();
TestingLogger::setLogLevel(log::LogLevel::TRACE);

/// @todo iox-#1755 register signal handler for sigterm to flush to logger;
/// there might be tests to register a handler itself and when this is
/// done at each start of the test only the tests who use their
/// own signal handler are affected and don't get an log output on termination
std::set_terminate([]() {
std::cout << "Terminate called\n" << std::flush;
dynamic_cast<TestingLogger&>(log::Logger::get()).printLogBuffer();
std::abort();
});

#if !defined(_WIN32)
struct sigaction action = {};
memset(&action, 0, sizeof(struct sigaction));
sigemptyset(&action.sa_mask);

action.sa_flags = SA_NODEFER;
action.sa_sigaction = sigHandler;

sigaction(SIGSEGV, &action, nullptr);
sigaction(SIGFPE, &action, nullptr);
#endif
}

void LogPrinter::OnTestPartResult(const ::testing::TestPartResult& result)
Expand Down