iox-#66 Remove 'ObjectPool'

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

The FixedPositioinContainer fulfills the remaining use-cases of the ObjectPool in iceoryx. Therefore the ObjectPool can be removed from the code base.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Cleanup or Remove ObjectPool #66

[elBoberido]

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

[codecov]

Codecov Report

Merging #2054 (a7f4165) into master (2a0be7b) will decrease coverage by 0.14%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
- Coverage   80.23%   80.10%   -0.14%     
==========================================
  Files         419      416       -3     
  Lines       16208    16026     -182     
  Branches     2298     2250      -48     
==========================================
- Hits        13005    12837     -168     
  Misses       2384     2384              
+ Partials      819      805      -14     

Flag	Coverage Δ
unittests	79.88% <87.50%> (-0.14%)	⬇️
unittests_timing	15.31% <0.00%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../include/iceoryx_posh/internal/gateway/channel.inl	90.47% <87.50%> (ø)

... and 10 files with indirect coverage changes

[FerdinandSpitzschnueffler]

Do we usually name the issue title here, or what has been done? It reads strange because "cleanup" and "remove" are contrary.

[elBoberido]

Yes, at least I usually copy the issue description ... not sure if everybody does the same