Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAndAssignmentTracker' #2058

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 24, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

On popular demand 'CTorAndAssignmentOperatorTestClass' is renamed to 'LifetimeAndAssignmentTracker' :)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the refactoring Refactor code without adding features label Oct 24, 2023
@elBoberido elBoberido self-assigned this Oct 24, 2023
@elBoberido elBoberido linked an issue Oct 24, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elBoberido elBoberido force-pushed the iox-1361-use-shared-memory-for-process-alive-detection branch from d725812 to c5bd28b Compare October 25, 2023 21:48
@elBoberido elBoberido force-pushed the iox-2041-rename-test-class branch from c0fb9d4 to a9a4a22 Compare October 25, 2023 21:51
@elBoberido elBoberido force-pushed the iox-1361-use-shared-memory-for-process-alive-detection branch from c5bd28b to 2f92bb0 Compare October 25, 2023 23:26
@elBoberido elBoberido force-pushed the iox-2041-rename-test-class branch from a9a4a22 to 50ced06 Compare October 25, 2023 23:28
@elBoberido elBoberido changed the title [Stacked on #2056] iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAndAssignmentTracker' iox-#2041 Rename 'CTorAndAssignmentOperatorTestClass' to 'LifetimeAndAssignmentTracker' Oct 30, 2023
@elBoberido
Copy link
Member Author

I'll merge this to the base branch. It is not that big and the approvals would be dismissed once I merge the base branch sot master. You'll have to re-approve on the base branch

@elBoberido elBoberido merged commit b1c74a1 into iox-1361-use-shared-memory-for-process-alive-detection Oct 30, 2023
17 checks passed
@elBoberido elBoberido deleted the iox-2041-rename-test-class branch October 30, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move test class for ctor and assignment operators to hoofs testing
3 participants