-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2066 Switch to C++17 #2096
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 80.17% 80.29% +0.11%
==========================================
Files 418 417 -1
Lines 16124 16110 -14
Branches 2250 2250
==========================================
+ Hits 12928 12935 +7
+ Misses 2398 2380 -18
+ Partials 798 795 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
079b6b8
to
5ed5231
Compare
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! 🥳
The PR looks good to me, with C++23 being released in a couple of weeks and many ISO 262626-certified compilers supporting C++17 I think we're ready to go for the v3.0
C release. This together with the iceoryx_hoofs
restructuring will become the main two features of the next release.
The date for moving to C++20 would then be roughly the end of 2026 😁 I can't wait for modules and concepts.
@mossmaurice I hope the compiler vendors manage to get their act together and fully implement modules by then 😅 |
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR moves the last two platforms, Linux and QNX, to the C++17 language standard. This means that we can start using C++17 features.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References