Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bazel 7.0.0 #2242

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Upgrade bazel 7.0.0 #2242

merged 3 commits into from
Apr 3, 2024

Conversation

phongt
Copy link
Contributor

@phongt phongt commented Apr 2, 2024 •
edited by elfenpiff
Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

phongt added 2 commits April 2, 2024 22:08
@phongt
iox-eclipse-iceoryx#2138 Fix Using bazel 7.0.0
ad3f4ff
@phongt
iox-eclipse-iceoryx#2138 Fix hoofs_moduletests with bazel 7.0.0
7a602f0 
add 'requires-fakeroot' tag for running the test as uid and gid 0
fixing the fail tests:
PosixAcl_test.writeSpecialGroupPermissions
PosixAcl_test.writeSpecialPermissionsWithID
lalten
lalten reviewed Apr 2, 2024
View reviewed changes
.bazelversion Outdated
@@ -1,2 +1 @@
6.4.0
# NOTE: Bazel 7.0 errors out on 'buildifier_lint_check' with a hint to 'go_register_toolchains' in 'setup.bzl'
7.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not go for 7.1.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not go for 7.1.1?

done c6626a5

@elfenpiff elfenpiff self-requested a review April 3, 2024 06:08
@elfenpiff
Copy link
Contributor

@phongt thank you very much for taking care of bazel.

@elfenpiff elfenpiff merged commit 166c6ca into eclipse-iceoryx:master Apr 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalten lalten lalten left review comments

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'buildifier_lint_check' broken with bazel 7
3 participants
@phongt @elfenpiff @lalten