Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2244 Add ekxide.io as vendor #2245

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 5, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff elfenpiff requested a review from elBoberido April 5, 2024 15:42
@elfenpiff elfenpiff self-assigned this Apr 5, 2024
@elfenpiff elfenpiff requested a review from budrus April 5, 2024 15:43
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (20bb7e5) to head (a612cb1).

❗ Current head a612cb1 differs from pull request most recent head f9f87b2. Consider uploading reports for the commit f9f87b2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   78.52%   78.51%   -0.01%     
==========================================
  Files         431      431              
  Lines       16631    16631              
  Branches     2333     2333              
==========================================
- Hits        13059    13058       -1     
  Misses       2707     2707              
- Partials      865      866       +1     
Flag Coverage Δ
unittests 78.31% <ø> (-0.01%) ⬇️
unittests_timing 15.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox-2244-add-ekxide-as-vendor branch from 215bb9a to a612cb1 Compare April 5, 2024 17:51
@elfenpiff elfenpiff force-pushed the iox-2244-add-ekxide-as-vendor branch from a612cb1 to f9f87b2 Compare April 5, 2024 17:58
@elBoberido elBoberido merged commit 515bcf6 into eclipse-iceoryx:master Apr 5, 2024
22 of 24 checks passed
@elBoberido elBoberido deleted the iox-2244-add-ekxide-as-vendor branch April 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ekxide.io as vendor that provides services for iceoryx
3 participants