Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Update github actions #2249

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 12, 2024

Notes for Reviewer

Update github actions to fix deprecation warnings and fix FreeBSD job.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff April 12, 2024 20:22
@elBoberido elBoberido self-assigned this Apr 12, 2024
@elBoberido elBoberido force-pushed the iox-2011-update-github-actions branch from 722af5b to b07399e Compare April 12, 2024 20:35
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (9a81c23) to head (c36b875).
Report is 2 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2249      +/-   ##
===============================================
- Coverage        78.83%   78.42%   -0.41%     
===============================================
  Files              370      370              
  Lines            14716    14220     -496     
  Branches          2061     2061              
===============================================
- Hits             11601    11152     -449     
+ Misses            2432     2383      -49     
- Partials           683      685       +2     
Flag Coverage Δ
unittests 77.65% <ø> (-0.40%) ⬇️
unittests_timing 15.12% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 149 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2011-update-github-actions branch 2 times, most recently from 4c56afa to dced983 Compare April 15, 2024 15:37
@elBoberido elBoberido force-pushed the iox-2011-update-github-actions branch from dced983 to c36b875 Compare April 15, 2024 15:55
@elBoberido elBoberido merged commit 1983be8 into eclipse-iceoryx:release_2.0 Apr 15, 2024
14 checks passed
@elBoberido elBoberido deleted the iox-2011-update-github-actions branch April 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants