Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1293 Document workaround for documentation in internal headers #2250

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 13, 2024

Notes for Reviewer

This PR documents the workaround we used to include the documentation in internal headers which where referenced by a trampoline header.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the documentation Improvements or additions to documentation label Apr 13, 2024
@elBoberido elBoberido requested a review from mossmaurice April 13, 2024 16:04
@elBoberido elBoberido self-assigned this Apr 13, 2024
@elBoberido elBoberido force-pushed the iox-1293-document-workaround-for-documentation-in-internal-headers branch from 14b35b0 to 08a98fe Compare April 13, 2024 16:06
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos

doc/aspice_swe3_4/swe_docu_guidelines.md Show resolved Hide resolved
@elBoberido elBoberido merged commit 79e6bce into eclipse-iceoryx:master Apr 14, 2024
24 checks passed
@elBoberido elBoberido deleted the iox-1293-document-workaround-for-documentation-in-internal-headers branch April 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't exclude implementations of public classes in Doxygen
2 participants