Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2270 Update links to default branch #2271

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 22, 2024

Notes for Reviewer

This PR changes all the links and CI config to use the new default branch main

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added documentation Improvements or additions to documentation tooling All iceoryx related tooling (scripts etc.) labels Apr 22, 2024
@elBoberido elBoberido requested a review from elfenpiff April 22, 2024 15:39
@elBoberido elBoberido self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (f00cfe0) to head (f534e86).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2271   +/-   ##
=======================================
  Coverage   78.12%   78.13%           
=======================================
  Files         432      432           
  Lines       15894    15894           
  Branches     2297     2297           
=======================================
+ Hits        12417    12418    +1     
  Misses       2631     2631           
+ Partials      846      845    -1     
Flag Coverage Δ
unittests 77.95% <ø> (+<0.01%) ⬆️
unittests_timing 14.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@elBoberido elBoberido merged commit e1c82d6 into eclipse-iceoryx:main Apr 22, 2024
25 checks passed
@elBoberido elBoberido deleted the iox-2270-update-links-to-default-branch branch April 22, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to default branch
2 participants