Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2278 Split up tests #2281

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 25, 2024

Notes for Reviewer

This PR splits up some tests into multiple files. On my system the compile time was reduced by 20 seconds (~13%) and clang-tidy execution time was reduced by more than 13 minutes (~50%).

There are still some files which take more than 7 minutes to scan but the two with 10 and 20 minutes are gone.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff April 25, 2024 01:16
@elBoberido elBoberido self-assigned this Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (f069696) to head (e1d4436).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   78.05%   78.04%   -0.01%     
==========================================
  Files         432      432              
  Lines       15912    15912              
  Branches     2303     2303              
==========================================
- Hits        12420    12419       -1     
- Misses       2644     2645       +1     
  Partials      848      848              
Flag Coverage Δ
unittests 77.87% <ø> (-0.01%) ⬇️
unittests_timing 14.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido elBoberido merged commit 562d9c1 into eclipse-iceoryx:main Apr 26, 2024
25 checks passed
@elBoberido elBoberido deleted the iox-2278-split-up-tests branch April 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'iox::string' tests can exceed the translation unit compilation timeout
2 participants