-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1755 Use upper camel case for LogLevel enum tags #2405
Merged
elBoberido
merged 4 commits into
eclipse-iceoryx:main
from
elBoberido:iox-1755-make-log-enum-tags-upper-camel-case
Jan 8, 2025
Merged
iox-#1755 Use upper camel case for LogLevel enum tags #2405
elBoberido
merged 4 commits into
eclipse-iceoryx:main
from
elBoberido:iox-1755-make-log-enum-tags-upper-camel-case
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
force-pushed
the
iox-1755-make-log-enum-tags-upper-camel-case
branch
3 times, most recently
from
January 8, 2025 00:38
56d928a
to
2221186
Compare
elfenpiff
previously approved these changes
Jan 8, 2025
elBoberido
force-pushed
the
iox-1755-make-log-enum-tags-upper-camel-case
branch
from
January 8, 2025 00:50
2221186
to
292dbe1
Compare
elBoberido
force-pushed
the
iox-1755-make-log-enum-tags-upper-camel-case
branch
from
January 8, 2025 00:58
7c11f82
to
4fb2c8d
Compare
elfenpiff
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
The
ERROR
log level causes issues on Windows since there is anERROR
define on the Windows platform. To prevent future issues, allLogLevel
enum tags follow now the upper camel case naming convention.The main issue is that upper snake case is usually used for defines and macros and with the short names, there is quite a high chance that those names are already used somewhere else. Using upper camel case should reduce the probability of name clashes.
It was also required to update the clang-format version.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References