Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Fix clang-tidy warning #2410

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 10, 2025

Notes for Reviewer

With the introduction of clang-tidy 18, a new warning was found. This PR fixes that warning.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido merged commit b4f81fc into eclipse-iceoryx:main Jan 10, 2025
19 of 21 checks passed
@elBoberido elBoberido deleted the iox-2011-fix-nightly-clang-tidy branch January 10, 2025 16:28
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.36%. Comparing base (6794c8e) to head (f7fc083).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6794c8e) and HEAD (f7fc083). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6794c8e) HEAD (f7fc083)
unittests 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2410       +/-   ##
===========================================
- Coverage   78.69%   15.36%   -63.34%     
===========================================
  Files         440      440               
  Lines       16981    16981               
  Branches     2361     2361               
===========================================
- Hits        13364     2609    -10755     
- Misses       2736    14054    +11318     
+ Partials      881      318      -563     
Flag Coverage Δ
unittests ?
unittests_timing 15.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...yx_hoofs/concurrent/sync/include/iox/spin_lock.hpp 0.00% <ø> (-100.00%) ⬇️

... and 352 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants