Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2414 Reset index after move construction #2413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

iox-#2414 Reset index after move construction #2413

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
181c48d
Reset index after move construction
yuanxingyang Jan 16, 2025
70d1817
iox-#2414 Reset index after move construction
yuanxingyang Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions iceoryx_hoofs/vocabulary/include/iox/detail/variant.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ inline constexpr variant<Types...>::variant(variant&& rhs) noexcept
if (m_type_index != INVALID_VARIANT_INDEX)
{
internal::call_at_index<0, Types...>::moveConstructor(m_type_index, &rhs.m_storage, &m_storage);
rhs.m_type_index = INVALID_VARIANT_INDEX;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if this also required for the move assignment operator?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @elBoberido
I have submitted an additional patch. Please review it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuanxingyang looks good. Let's see what the CI tells us. Maybe a suppression for a warning accessing a moved object needs to be added.

Did you already signed the ECA? It can take some time until everything is synced.

Can you also please add the issue number to the first commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seems you need to run clang-format on the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and forget my question regarding the ECA 😅

}
}

Expand Down