-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#508] event concept based on socketpair #598
base: main
Are you sure you want to change the base?
[#508] event concept based on socketpair #598
Conversation
94535f3
to
1b30800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 78.77% 78.86% +0.08%
==========================================
Files 199 200 +1
Lines 24118 24443 +325
==========================================
+ Hits 18999 19276 +277
- Misses 5119 5167 +48
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. No obvious reason why the Windows CI fails.
I guess you need to add iceoryx2_bb_log
to the iceoryx2-cal-tests
bazel target.
Notes for Reviewer
Implemented the process local variant of events using socketpairs. Required - otherwise we do not have a real process local event variant, currently we use unix domain sockets with a file representation.
Windows required also a
dup
implementation on the platform since the notifier socket is acquired by duplicating one of the sockets from the socket pair since an event concept on that level is a M:1 connection (many notifiers and one listener) but a socketpair creates just 2 sockets.Pre-Review Checklist for the PR Author
Convert to draft
)SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #508