Skip to content

Make SpotBugs annotations available to PDE (fixes #201) - #205

Merged
kgibm merged 2 commits into
eclipse-mat:masterfrom
jasonk000:fix/spotbugs-pde-classpath
Oct 8, 2026
Merged

kgibm merged 2 commits into
eclipse-mat:masterfrom
jasonk000:fix/spotbugs-pde-classpath

Conversation

@jasonk000

Copy link
Copy Markdown
Contributor

I cannot validate this e2e as I do not have local Eclipse install. Something like this should fix #201. Follow these instructions @kgibm.

Please update to the branch containing the target-platform fix, open org.eclipse.mat.targetdef/mat-2026-06.target, and select Set as Active Target Platform.

If it was already active, use Reload first.

Then run Project → Clean.

The target now provides edu.umd.cs.findbugs.annotations to PDE as an optional compile-time package; SpotBugs is not added as a MAT runtime dependency.

@kgibm kgibm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing that extra newline, this solution worked, thanks!

org.eclipse.mat.snapshot.query,
org.eclipse.mat.snapshot.registry
Import-Package: edu.umd.cs.findbugs.annotations;resolution:=optional

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra newline causes an error

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, please take a look after bb9f14d.

@jasonk000
jasonk000 requested a review from kgibm September 28, 2026 20:36
@kgibm
kgibm merged commit 7fb6d72 into eclipse-mat:master Oct 8, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SpotBugs errors developing in Eclipse

2 participants