Simplify AsynchExecThread to avoid duplicate barrier state upgrade

eclipse-platform · Dec 19, 2023 · 9f8ae54 · 9f8ae54
1 parent 4b9ad9c
commit 9f8ae54
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/....eclipse.core.tests.runtime/src/org/eclipse/core/tests/runtime/jobs/AsynchExecThread.java b/....eclipse.core.tests.runtime/src/org/eclipse/core/tests/runtime/jobs/AsynchExecThread.java
@@ -49,17 +49,13 @@ public void run() {
 
 		//must have positive work
 		current.beginTask(jobName, 1);
-		try {
-			if (current.isCanceled()) {
-				barrier.upgradeTo(TestBarrier2.STATUS_DONE);
-				job.done(Status.CANCEL_STATUS);
-			}
-			current.worked(1);
-		} finally {
-			barrier.upgradeTo(TestBarrier2.STATUS_DONE);
-			current.done();
+		if (current.isCanceled()) {
+			job.done(Status.CANCEL_STATUS);
+		} else {
 			job.done(Status.OK_STATUS);
 		}
+		barrier.upgradeTo(TestBarrier2.STATUS_DONE);
+		current.done();
 	}
 
 }