Rewrite JobTest#testSetProgressGroup #1026 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 594 files ± 0 594 suites ±0 37m 40s ⏱️ - 5m 52s Results for commit 128ca1f. ± Comparison against base commit 6ed9800. This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-1026
branch
2 times, most recently
from
a2dff31 to
829beac
Compare
The test method JobTest#testSetProgressGroup mixes up at least five test cases into one method. This makes it hard to comprehend what actually is tested and to identify the reasons for a failure. This change splits up the five test cases into separate methods with names reflecting their purpose and a reduced setup to what is necessary for the test case. Since the original test method is randomly failing, this change will make it easier to find the reasons. Contributes to eclipse-platform#1026
HeikoKlare
force-pushed
the
issue-1026
branch
from
829beac to
128ca1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test method JobTest#testSetProgressGroup mixes up at least five test cases into one method. This makes it hard to comprehend what actually is tested and to identify the reasons for a failure. This change splits up the five test cases into separate methods with names reflecting their purpose and a reduced setup to what is necessary for the test case. Since the original test method is randomly failing, this change will make it easier to find the reasons.
Contributes to #1026