Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traceability KIT 24.08] Updated Software Development View #936

Conversation

johannsvarela
Copy link
Contributor

Description

Added new aspect models into the Software Development View. For more details have a look at the changelog.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@johannsvarela
Copy link
Contributor Author

@mhellmeier @arnoweiss please have a look at this PR. Thanks!

@johannsvarela
Copy link
Contributor Author

@mhellmeier my fault! I've adapted the changelog to include the 5.01 section again. Please review the changes.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johannsvarela, thank you for the contribution.

I have a few questions:

@mhellmeier
Copy link
Member

This pull request is only a small addition to release 24.08. The #980 is the main PR for the 24.08 release.

I suggest changing the target branch of this PR to docs/trace-industry-core-release-24.08 so that this can be merged first and afterward with #980 in the main branch.

@johannsvarela johannsvarela changed the base branch from main to docs/trace-industry-core-release-24.08 July 23, 2024 08:31
Copy link
Contributor

@markuskeidl markuskeidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your local branch first will all updates from the main branch (eclipse-tractusx:docs/trace-industry-core-release-24.08 and update the PR, so that the PR only shows your changes.

Copy link
Contributor

@eckardg eckardg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the comments from Markus Keidl and myself.

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johannsvarela, thank you for the contribution. I have a few remarks, which should be easy to fix.

But please consider: The openAPI plugin will be discontinued and the API and the respective MDX-files needs to be removed, please see the following guidance: #970

@johannsvarela johannsvarela changed the base branch from docs/trace-industry-core-release-24.08 to main July 24, 2024 10:57
@mhellmeier mhellmeier changed the base branch from main to docs/trace-industry-core-release-24.08 July 24, 2024 13:53
@mhellmeier mhellmeier merged commit 7e0e305 into eclipse-tractusx:docs/trace-industry-core-release-24.08 Jul 24, 2024
2 checks passed
@johannsvarela johannsvarela deleted the docs-kits/traceability-aspect-models-release-24.08 branch July 25, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants