-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traceability KIT 24.08] Updated Software Development View #936
[Traceability KIT 24.08] Updated Software Development View #936
Conversation
@mhellmeier @arnoweiss please have a look at this PR. Thanks! |
@mhellmeier my fault! I've adapted the changelog to include the 5.01 section again. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johannsvarela, thank you for the contribution.
I have a few questions:
- Is there a corresponding Release Check Ticket in sig-release? I can't find one for the Traceability nor for the Industry Core Kit.
- How does this PR relate to
docs: prepare release for Industry Core and Traceability KIT (24.08.) #980 - Currently, the semantic models "SoftwareInformation" and "CertificateSigningRequests" are not covered by the respective standards.
docs-kits/kits/Industry Core Kit/Software Development View/part_aspect-model-overview.mdx
Outdated
Show resolved
Hide resolved
…traceability-aspect-models-release-24.08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your local branch first will all updates from the main branch (eclipse-tractusx:docs/trace-industry-core-release-24.08 and update the PR, so that the PR only shows your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the comments from Markus Keidl and myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johannsvarela, thank you for the contribution. I have a few remarks, which should be easy to fix.
But please consider: The openAPI plugin will be discontinued and the API and the respective MDX-files needs to be removed, please see the following guidance: #970
docs-kits/kits/Industry Core Kit/Software Development View/part_aspect-model-overview.mdx
Outdated
Show resolved
Hide resolved
…traceability-aspect-models-release-24.08
7e0e305
into
eclipse-tractusx:docs/trace-industry-core-release-24.08
Description
Added new aspect models into the Software Development View. For more details have a look at the changelog.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: