feat(app & service release process): resume last edited page during release process #1376
Conversation
There was a problem hiding this comment.
@kunalgaurav-bmw please see #1335 (comment)
@manojava-gk @lavanya-bmw please review
|
@kunalgaurav-bmw its not registration process -> it is release process. Pls change the text in both title and description |
|
@kunalgaurav-bmw could you pls confirm whether only mandatory fields are being checked to increment or decrement the step? |
kunalgaurav-bmw
changed the title
Hi @manojava-gk I have done this changes in useEffect in the following way for the all steps and all the mandatory fields I have added in if condition useEffect(() => { |
|
|
@kunalgaurav-bmw Is it possible to determine the step based on response in the first step itself? Create a helper file and move all the step specific conditions to the respective places, component will have only one condition in first step to determine the actual step. All the step based condition will be hosted in the main method as shown above |
| return () => { | ||
| dispatch(setAppRedirectStatus(true)) | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
I haven't seen this pattern in our code before. This returns a cleanup function as described in https://react.dev/reference/react/useEffect#parameters - if the dependency array is empty what difference does it make to not simply call the function but return an internal function?
useEffect(() => {
dispatch(setAppRedirectStatus(true))
}, [])
| dispatch(setServiceRedirectStatus(true)) | ||
| } | ||
| }, []) | ||
|
|
There was a problem hiding this comment.
another cleanup function - see my other comment. can you explain the need for that?
| dispatch(increment()) | ||
| hasDispatched.current = true | ||
| } | ||
| }, [fetchAppStatus, hasDispatched]) |
There was a problem hiding this comment.
This seems quite complicated and hard to follow. What issue are you trying to solve here?
| hasDispatched.current = true | ||
| } | ||
| }, [fetchAppStatus, hasDispatched]) | ||
|
|
Description
Resume to the last edited page during App/Service release process.
Changelog entry:
Why
Currently if I stop the release process and then get back to the app/service I need to click through all the steps I fulfilled already, It should be automatically resume to the last page where user stop.
Issue
#1335
Checklist
Please delete options that are not relevant.