Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mobile navigation bar enhancement #1432

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JordanGerada3
Copy link
Contributor

As part of the discussion with the Catena-X portal team, it was discussed and agreed upon that Cofinity-X would contribute the Cofinity-X navigation bar and mobile menu.

This feature is spit into two parts. A contribution to the portal repo which contains code that upgrades the mobile navigation and a contribution to the shared components, which upgrades components used in the main navigation and user menu.

Shared components PR: eclipse-tractusx/portal-shared-components#407

Description

  • Updated MenuInfo component
  • Updated MenuItem component
  • Update logo component
  • New LogoutLink component
  • Updated mobile menu MenuChildren component
  • Updated mobile menu MenuFooter component
  • Updated mobile menu ProfileLink component
  • Updated Header component
  • Updated AccessService
  • Added new redux store & slice to store header note state
  • Added new menu constants
  • Added company role constants

Why

Cofinity-X uses a more concise and neat structure which handles a large amount of navigation items well. The idea of using this navigation structure was offered by Cofinity-X team and accepted by the open source community.

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@JordanGerada3 JordanGerada3 marked this pull request as ready for review January 15, 2025 14:05
@JordanGerada3 JordanGerada3 marked this pull request as draft January 15, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants