Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(centralidp): create decline_subscription permission #233

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Nov 22, 2024

Description

Permission created in in the Client Cl2-CX-Portal

Why

To enable a new backend api, we need to implement a new permission called decline_subscription in the Client Cl2-CX-Portal

Issue

Ref: #232

Corresponding Backend PR

eclipse-tractusx/portal-backend#1171

Checklist

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@tfjanjua tfjanjua self-assigned this Nov 22, 2024
@tfjanjua tfjanjua added the enhancement New feature or request label Nov 22, 2024
@tfjanjua tfjanjua requested a review from gitbooma November 22, 2024 10:38
@tfjanjua tfjanjua marked this pull request as ready for review November 22, 2024 14:32
@tfjanjua tfjanjua requested review from Phil91 and evegufy November 22, 2024 14:32
@evegufy evegufy changed the title feat(decline_subscription): Permission created in in the Client Cl2-CX-Portal feat(decline_subscription): create permission in the client Cl2-CX-Portal Nov 28, 2024
Phil91
Phil91 previously approved these changes Jan 13, 2025
@Phil91
Copy link
Member

Phil91 commented Jan 16, 2025

@tfjanjua could you please rebase and resolve the conflicts? the backend pr is already merged

@tfjanjua tfjanjua force-pushed the feat/232-createPermission-decline_subscription branch from 15e184c to d698cfa Compare January 20, 2025 10:10
@tfjanjua tfjanjua requested a review from Phil91 January 20, 2025 10:12
@tfjanjua
Copy link
Contributor Author

@tfjanjua could you please rebase and resolve the conflicts? the backend pr is already merged

Hi @Phil91 , thanks for the backend change merge, conflicts has been resolved and branch has been rebased.

@evegufy evegufy changed the title feat(decline_subscription): create permission in the client Cl2-CX-Portal feat(centralidp): create decline_subscription permission Jan 20, 2025
@evegufy evegufy merged commit 2fa79ee into eclipse-tractusx:main Jan 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants