fix: Resolve App details image duplications #290
Conversation
|
Hi @oyo @lavanya-bmw, can you review this when you can? It's really a terrible user experience for the marketplace. Thanks! |
| const getIsInfinite = () => { | ||
| if (mobile) return gallery?.length > 1 | ||
| else if (tab) return gallery?.length > 2 | ||
| else return gallery?.length > 3 |
There was a problem hiding this comment.
please remove else in both lines above because it's not needed when return in the if clause is guaranteed
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| - **chor:** run pretty explicitly ([702a9dc](https://github.com/eclipse-tractusx/portal-shared-components/commit/702a9dc7ca0ef003593ec5ad0ddf8459d92320f2)) | |||
| - **chor:** update deoendency file ([bb45f76](https://github.com/eclipse-tractusx/portal-shared-components/commit/bb45f761102e442fd727b10f5a1d0362a0f124cf)) | |||
| - **chro:** update the package version ([506dc70](https://github.com/eclipse-tractusx/portal-shared-components/commit/506dc709a28e19cbfc2dd6ea38f3af60ed3ef74c)) | |||
| - **ImageGallery:** Resolve duplicates image issue ([#288](https://github.com/eclipse-tractusx/portal-shared-components/issues/288)) | |||
There was a problem hiding this comment.
remove entry because release-please will generate one based on your commit messages
There was a problem hiding this comment.
@oyo so we don't need to update the change log in shared components, only in the other repos. Do you confirm? Just to pass the knowledge to other FE devs.
|
|
Hi @oyo, Thank you! 😊 |
Description
Why
Issue
Checklist