Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BPDM): Set BPDM pool url #472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(BPDM): Set BPDM pool url #472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc0e8d
chore(BPDM): Set BPDM pool url
tfjanjua Oct 29, 2024
28bedb6
fix review points
tfjanjua Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/portal/templates/cronjob-backend-processes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ spec:
value: "{{ .Values.backend.useDimWallet }}"
- name: "APPLICATIONCHECKLIST__BPDM__STARTSHARINGSTATEASREADY"
value: "{{ .Values.backend.processesworker.bpdm.startSharingStateAsReady }}"
- name: "APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS"
value: "{{ .Values.bpdm.poolAddress }}{{ .Values.bpdm.poolApiPath }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is referring to a path:

portal/environments/helm-values/values-int.yaml

Line 28 in 4079002

poolApiPath: "/pool/v6"

but expected is a full url:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L188

Copy link
Contributor Author

@tfjanjua tfjanjua Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS has the following value:

https://business-partners-pool.example.com/pool/v6

and rest of the url part (v6/cx-memberships) has already been placed while calling it from httpClient:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L195C42-L195C59

So, its like:
https://business-partners-pool.example.com/pool/v6/v6/cx-memberships

So, I think no full url is expected.

However, since url part (v6/cx-memberships) has already been placed so, I can remove the poolApiPath from the value of config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS

So, then config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS will be:

https://business-partners-pool.example.com/

and rest of the url part (v6/cx-memberships) will make it:

https://business-partners-pool.example.com/v6/cx-memberships

- name: "APPLICATIONCHECKLIST__CLEARINGHOUSE__BASEADDRESS"
value: "{{ .Values.clearinghouseAddress }}"
- name: "APPLICATIONCHECKLIST__CLEARINGHOUSE__CLIENTID"
Expand Down
2 changes: 2 additions & 0 deletions charts/portal/templates/deployment-backend-administration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ spec:
value: "{{ .Values.backend.useDimWallet }}"
- name: "APPLICATIONCHECKLIST__BPDM__STARTSHARINGSTATEASREADY"
value: "{{ .Values.backend.processesworker.bpdm.startSharingStateAsReady }}"
- name: "APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS"
value: "{{ .Values.bpdm.poolAddress }}{{ .Values.bpdm.poolApiPath }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is referring to a path:

portal/environments/helm-values/values-int.yaml

Line 28 in 4079002

poolApiPath: "/pool/v6"

but expected is a full url:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L188

Copy link
Contributor Author

@tfjanjua tfjanjua Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS has the following value:

https://business-partners-pool.example.com/pool/v6

and rest of the url part (v6/cx-memberships) has already been placed while calling it from httpClient:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L195C42-L195C59

So, its like:
https://business-partners-pool.example.com/pool/v6/v6/cx-memberships

So, I think no full url is expected.

However, since url part (v6/cx-memberships) has already been placed so, I can remove the poolApiPath from the value of config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS

So, then config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS will be:

https://business-partners-pool.example.com/

and rest of the url part (v6/cx-memberships) will make it:

https://business-partners-pool.example.com/v6/cx-memberships

- name: "APPLICATIONCHECKLIST__CLEARINGHOUSE__BASEADDRESS"
value: "{{ .Values.clearinghouseAddress }}"
- name: "APPLICATIONCHECKLIST__CLEARINGHOUSE__CLIENTID"
Expand Down