Skip to content

Commit

Permalink
Update to Node 20
Browse files Browse the repository at this point in the history
Theia dropped support for v18. So we upgrade to v20 too.

Contributed on behalf of STMicroelectronics.
  • Loading branch information
planger committed Aug 20, 2024
1 parent 8636434 commit 9e3a7dc
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ on:

jobs:
build:
name: E2E Tests on ubuntu-latest with Node.js 18.x
name: E2E Tests on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
timeout-minutes: 60

steps:
- name: Checkout
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0

- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'

- name: Use Python 3.11
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
key: ${{ github.run_number }}

browser-tests:
name: E2E Browser Tests on ubuntu-latest with Node.js 18.x
name: E2E Browser Tests on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
timeout-minutes: 60
needs: [build]
Expand All @@ -82,10 +82,10 @@ jobs:
key: ${{ github.run_number }}
fail-on-cache-miss: true

- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'

- name: Use Python 3.11
Expand All @@ -109,7 +109,7 @@ jobs:
path: allure-results/*

electron-tests:
name: E2E Electron Tests on ubuntu-latest with Node.js 18.x
name: E2E Electron Tests on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
timeout-minutes: 60
needs: [build]
Expand All @@ -123,10 +123,10 @@ jobs:
key: ${{ github.run_number }}
fail-on-cache-miss: true

- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'

- name: Use Python 3.11
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ on:

jobs:
prepare:
name: Performance benchmark on ubuntu-latest with Node.js 18.x
name: Performance benchmark on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'
- name: Use Python 3.11
uses: actions/setup-python@b64ffcaf5b410884ad320a9cfac8866006a109aa # v4.8.0
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
key: ${{ github.run_number }}

run-browser-tests:
name: Performance browser benchmark on ubuntu-latest with Node.js 18.x
name: Performance browser benchmark on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
needs: [prepare]
strategy:
Expand All @@ -88,10 +88,10 @@ jobs:
path: ./*
key: ${{ github.run_number }}
fail-on-cache-miss: true
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'
- name: Use Python 3.11
uses: actions/setup-python@b64ffcaf5b410884ad320a9cfac8866006a109aa # v4.8.0
Expand All @@ -118,7 +118,7 @@ jobs:
path: performance-metrics/*

run-electron-tests:
name: Performance electron benchmark on ubuntu-latest with Node.js 18.x
name: Performance electron benchmark on ubuntu-latest with Node.js 20.x
runs-on: ubuntu-latest
needs: [prepare]
strategy:
Expand All @@ -133,10 +133,10 @@ jobs:
path: ./*
key: ${{ github.run_number }}
fail-on-cache-miss: true
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
with:
node-version: 18.x
node-version: 20.x
registry-url: 'https://registry.npmjs.org'
- name: Use Python 3.11
uses: actions/setup-python@b64ffcaf5b410884ad320a9cfac8866006a109aa # v4.8.0
Expand Down

0 comments on commit 9e3a7dc

Please sign in to comment.