-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InlineMember: rename duplicate locals in the body #172
Conversation
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 90 90
Lines 16690 16695 +5
=======================================
+ Hits 15379 15384 +5
Misses 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this. I have a small remark regarding the implementation, otherwise fine from my side.
Co-authored-by: Balthasar Reuter <[email protected]>
…to sbrm-inline-transform-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. Looks good to go!
The shadow mapper will only find variables in the declaration and leaves the body unchanged.
I do not understand the need for the
[dl.name for dl in duplicate_locals]
construct though. I would have thought that av in duplicate_locals
orv.name in duplicate_locals
would be sufficient.