Sourcefile does not have a filepath #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joscao
commented
Oct 23, 2023
joscao
commented
- sourcefile has a source not a filepath
- sourcefile has a source not a filename
joscao
changed the title
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 90 90
Lines 16690 16690
=======================================
Hits 15379 15379
Misses 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more. |
reuterbal
requested changes
Oct 23, 2023
tests/conftest.py
Outdated
| @@ -71,7 +71,7 @@ def jit_compile(source, filepath=None, objname=None): | |||
| Return a specific object (module or subroutine) in :attr:`source` | |||
| """ | |||
| if isinstance(source, Sourcefile): | |||
| filepath = source.filepath if filepath is None else Path(filepath) | |||
| filepath = source.source if filepath is None else Path(filepath) | |||
There was a problem hiding this comment.
I disagree, Sourcefile.source is an object of type Source rather than a path. However, the current implementation is also wrong, it should be using source.path rather than source.filepath:
Line 60 in af8ec9f
There was a problem hiding this comment.
Used path instead of source. bc8f27b
There was a problem hiding this comment.
Discovered that filepath can still be empty, therefore is starting to write in ".", avoid this by using tempdir
87bc181
reuterbal
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.