Transformations: Fix downcasing of nested InlineCall symbols
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested calls to functions is not captured in `convert_to_lower_case`, which can break the Fortran-to-Python converter. This simple fix remedies this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 96.03% 96.03% -0.01%
==========================================
Files 225 226 +1
Lines 40552 40581 +29
==========================================
+ Hits 38945 38972 +27
- Misses 1607 1609 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
changed the title
InlineCall symbolsInlineCall symbols
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/472/index.html |
reuterbal
approved these changes
Jan 15, 2025
reuterbal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested calls to functions is not captured in
convert_to_lower_case, which can break the Fortran-to-Python converter. This simple fix remedies this.