Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU E2E Test #1136

Open
wants to merge 1 commit into
base: msanft/gpu-runtime-class
Choose a base branch
from
Open

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jan 10, 2025

This adds an E2E test for GPU use on Contrast.
It currently runs on the GPU-enabled bare-metal SNP runner.

The test currently only verifies that the GPU is available via
nvidia-smi, which also verifies that driver and CUDA work correctly.

@msanft msanft added the no changelog PRs not listed in the release notes label Jan 10, 2025
@msanft msanft added this to the v1.4.0 milestone Jan 10, 2025
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from f1fcfd7 to e92e97d Compare January 10, 2025 12:55
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 2218242 to 5bfe77f Compare January 10, 2025 15:21
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from e92e97d to b24fc44 Compare January 10, 2025 15:23
e2e/gpu/testdata/gpu-pod.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e_on_pull_request.yml Outdated Show resolved Hide resolved
flake.nix Outdated
@@ -8,7 +8,7 @@
# see https://github.com/renovatebot/renovate/issues/29721 and
# https://github.com/renovatebot/renovate/blob/743fed0ec6ca5810e274571c83fa6d4f5213d4e7/lib/modules/manager/nix/extract.ts#L6.
# We must keep the following string in the file for renovate to work: "github:NixOS/nixpkgs/nixpkgs-unstable"
url = "github:NixOS/nixpkgs?ref=nixos-unstable";
url = "github:msanft/nixpkgs/msanft/libnvidia-container/driver-bins";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above does not apply anymore, and it would be good to have a note that says how we get back to unstable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is to be removed, see the message

@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 5bfe77f to fa64242 Compare January 13, 2025 07:41
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 4 times, most recently from f7384f3 to 1b54d8c Compare January 13, 2025 08:15
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from fa64242 to 8674ee5 Compare January 13, 2025 08:30
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from 1b54d8c to 437b977 Compare January 13, 2025 09:43
@msanft msanft force-pushed the msanft/gpu-runtime-class branch 2 times, most recently from a59e508 to 2c70c4e Compare January 14, 2025 08:05
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 2 times, most recently from 896901f to 9ee8c10 Compare January 14, 2025 08:18
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 2c70c4e to 1f69236 Compare January 14, 2025 08:26
@msanft msanft force-pushed the msanft/gpu-e2e-test branch 4 times, most recently from 60a66f5 to b8b5b31 Compare January 16, 2025 09:59
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from 1f69236 to acf8e0a Compare January 17, 2025 15:17
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from b8b5b31 to e91c280 Compare January 17, 2025 15:18
@msanft msanft force-pushed the msanft/gpu-runtime-class branch from acf8e0a to fe591c1 Compare January 17, 2025 16:37
This adds an E2E test for GPU use on Contrast.
It currently runs on the GPU-enabled bare-metal SNP runner.

The test currently only verifies that the GPU is available via
nvidia-smi, which also verifies that driver and CUDA work correctly.
@msanft msanft force-pushed the msanft/gpu-e2e-test branch from e91c280 to 3bd65be Compare January 17, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants