Skip to content

Move UnstableFn containers to sequence storage - #984

Draft
ezrosent wants to merge 1 commit into
codex/inline-containers-10-pairfrom
codex/inline-containers-11-unstable-fn
Draft

ezrosent wants to merge 1 commit into
codex/inline-containers-10-pairfrom
codex/inline-containers-11-unstable-fn

Conversation

@ezrosent

@ezrosent ezrosent commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Encode UnstableFn values as self-describing sequences containing the opaque descriptor, argument count, rebuild masks, and partial arguments.
  • Rebuild argument lanes without resolving the descriptor through BaseValues.
  • Add prepared functions that resolve and copy partial arguments once for repeated higher-order callbacks.
  • Cover multiword masks, malformed encodings, descriptor-free rebuilds, nested dirty propagation, and application after rebuild.

Stack

Draft, stacked on #983. This is PR 11 of 12 in the sequence-backed container stack.

Validation

Validated on the complete 12-commit stack:

  • cargo nextest run --workspace: 1,362 tests passed
  • cargo test --workspace --doc
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt --all -- --check

@codecov-commenter

codecov-commenter commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.38298% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.63%. Comparing base (729c201) to head (83b5f30).

Files with missing lines Patch % Lines
src/sort/fn.rs 97.69% 8 Missing ⚠️
src/exec_state.rs 82.14% 5 Missing ⚠️
core-relations/src/containers/sequence.rs 84.00% 4 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           codex/inline-containers-10-pair     #984      +/-   ##
===================================================================
- Coverage                            87.88%   87.63%   -0.25%     
===================================================================
  Files                                  103      103              
  Lines                                39568    39936     +368     
===================================================================
+ Hits                                 34773    34997     +224     
- Misses                                4795     4939     +144     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 37 untouched benchmarks
⏩ 227 skipped benchmarks1


Comparing codex/inline-containers-11-unstable-fn (83b5f30) with codex/inline-containers-10-pair (729c201)

Open in CodSpeed

Footnotes

  1. 227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from 49c0d64 to 3be29f9 Compare August 6, 2026 05:34
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from 3be29f9 to 9c1b8e9 Compare August 10, 2026 05:20
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch 2 times, most recently from 6eef7db to b69d9fc Compare August 10, 2026 06:06
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from b69d9fc to 05f883b Compare August 10, 2026 06:54
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch 2 times, most recently from db6571b to ebc8824 Compare August 14, 2026 04:37
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from ebc8824 to 82da651 Compare August 14, 2026 04:55
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from 82da651 to 3316809 Compare August 14, 2026 05:02
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch 3 times, most recently from d1aa475 to a693c62 Compare August 14, 2026 05:15
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from a693c62 to 6a28888 Compare September 16, 2026 04:35
@ezrosent
ezrosent removed this pull request from stack #989 September 16, 2026 04:35
@ezrosent
ezrosent added this pull request to stack #1025 September 16, 2026 04:36
@ezrosent
ezrosent force-pushed the codex/inline-containers-11-unstable-fn branch from 6a28888 to 83b5f30 Compare September 18, 2026 05:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants