Add PICO annotation #106
Open
Add PICO annotation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
December 28, 2024 18:37
added 13 commits
December 28, 2024 20:56
wmdietl
reviewed
Dec 30, 2024
There was a problem hiding this comment.
You also need to add the new qualifier package to module-info.java.
| @@ -162,7 +165,8 @@ | |||
| "EnsuresNonNullIf(expression={\"list()\",\"list(FilenameFilter)\",\"listFiles()\",\"listFiles(FilenameFilter)\",\"listFiles(FileFilter)\"}, result=true)\"" | |||
| }) | |||
| @AnnotatedFor({"index", "initialization", "interning", "lock", "nullness"}) | |||
| public class File | |||
| @DefaultQualifierForUse(Readonly.class) | |||
There was a problem hiding this comment.
I am still thinking. At least for most usage in @RDM class, this make sense because we need to make the most method can be used for both @Immutable and @Mutable class like getters. Some methods can only be used by @Mutable receiver like add(...).
I am wondering should we default the defaultqualifierforuse to RDM for RDM class?
Done, thanks! |
# Conflicts: # src/java.base/share/classes/java/util/Objects.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.