-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparations for the next release #84
Conversation
Set a good example by applying the now-recommended config here.
That makes sense to me...I think it would be good to start putting changes into a legit CHANGELOG.md file so it's not just in the GitHub release notes (or README). Beyond that, it's updating the docs and references like you mentioned, bumping the version, signing a tag, and then pushing it to mark a release. If you like, I can handle the signing step once you're ready, but my basic process looks like this:
This will tag and sign a release via GPG:
...the signature can be verified if you have the proper public key in your GPG keyring with:
You can see a tagged release with:
Push your annotated tags to the remote repo with:
|
Hey there, when can we expect this PR to be merged roughly? For us it would be cool when #76 makes it into a new release :-) |
Hi @stherold we're moving slowly towards a release but we don't have a specific timeline in mind. Be aware that you don't need to wait for an official release to take advantage of the fix in #76, you can download and use the Here's the raw file link to the current |
Yup that's what I communicated in our team. This is also fine for now. Thanx fr the info :-) |
* master: Fix init of repo with --force when secrets file is deleted Add test demonstrating bug when init-ing repo with --force Fix unit tests to run and pass with OpenSSL >= 1.1 #74 Tell users about garbage collection now done as part of flush or uninstall #74 Avoid delete of cached plaintext objects on upgrading #74 Refactor removal of cached plaintext to a separate function #74 Fix cached plaintext removal to account for packed objects #74 Improve cached plaintext tests to trigger Git's object packing #74 Mention fix to clear cached unencrypted data on flush or uninstall #74 Remove cached plaintext of secret files on uninstall or flush #74 Add tests that fail due to cached plaintext after flush & uninstall Mention --upgrade command in README change notes Improve interactivity and feedback for --upgrade Add --upgrade option to re-install and add merge driver config Fix merge driver bug when merge can be done cleanly Improve handling of challenging file names when 'core.quotePath=true'
- move and tidied up notes from README.md - add steps to upgrade an existing repo to enable merge fix - mention various other fixes and improvements since 2.0.0
Hi @elasticdog I think everything in this PR is now up-to-date and we should be pretty close to being able to release version Can you please look over the changes here, especially the new CHANGELOG.md file and any new documentation or notes I have added, to make sure they are clear and correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of your hard work...this is looking great! The mixture of single/double brackets did surprise me, since I thought the plan was to use double brackets everywhere (#89 (comment))? They are technically safer, but that's a super minor point. The changelog is perfect.
I left a question about whether or not you wanted to work the contexts PR into this release, or handle it afterward. Either way is good with me. Feel free to pull the trigger on merging when you're ready, and I'd be glad to sign the release.
You're welcome @elasticdog, thanks for checking the changes. I have pushed improvements to always use double brackets I think it would be best to leave the contexts work to settle instead of rushing it into the 2.1.0 release, since I haven't used it at all myself day-to-day and I'm still finding rough edges and bugs in #89 |
@elasticdog I have squash-merged this branch to Let's release! |
Wasn't this PR intended for the 2.0.0 release? |
Version 2.0.0 is already out: https://github.com/elasticdog/transcrypt/releases/tag/v2.0.0 [Edit] I mean, it has been out for a long time. |
yeah I just noted down that this should be merged too for us to switch from the development (commit) version to a new tag. But since that was long ago I forgot why ^^ |
Sorry, I missed the original ping saying that this was merged and ready to go. I just cut a release...thanks again @jmurty! |
Thanks for releasing @elasticdog ! |
This PR is to collect and review any changes needed to prepare for the next transcrypt release.
TODOs:
test on Windows / WSL and maybe document git alias approach from WSL not work #61 in README for Windows, if that works--upgrade
command (if included)update BATS tests to always prefer single brackets[
]
around tests, and only use double brackets[[
]]
when needed for advanced features (like wildcard matching)[[
]]
around tests because they are safer2.1.0
@elasticdog please add or amend these TODOs so I can help out where I can.