Repository navigation
Stop restricting TLS listeners to the P-256 key exchange group - #20374
Open
bardiharborow wants to merge 1 commit into
Open
bardiharborow wants to merge 1 commit into
bardiharborow wants to merge 1 commit into
Conversation
Remove the `set_tmp_ecdh` call in `ServerContextFactory.configure_context`. On OpenSSL 1.1.0+ it replaced the default list of supported groups with only P-256, so TLS listeners could not negotiate X25519 or X25519MLKEM768. Signed-off-by: Bardi Harborow <bardi@bardiharborow.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
set_tmp_ecdhcall inServerContextFactory.configure_context. On OpenSSL 1.1.0+ it replaces the default list of supported groups with only P-256, so TLS listeners could not negotiate X25519 or X25519MLKEM768. The call was needed on OpenSSL 1.0.x, which enabled no curves by default. Synapse now requirescryptography>=3.4.7, so OpenSSL is always 1.1.0 or later. Twisted'sCertificateOptionsalready skips this step on 1.1.0+.Fixes #20373
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.