Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizes calls to css(), width() and height() for performance reasons #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nos3
Copy link

@nos3 nos3 commented Feb 12, 2014

Profiling has shown that calls of the jquery css() method consumed very much time when moving the lens. This resulted in lags when moving the lens fast in Firefox and IE. By optimizing the css() calls (and also width() / height() methods) and the their parameters, the lags are now almost gone.

slackero added a commit to slackero/elevatezoom that referenced this pull request Jan 23, 2015
elevateweb#40 Erase already created zoomContainer
elevateweb#43 Optimizes calls to css(), width() and height() for performance reasons
@igorlino
Copy link

@nsendetzky Hi there, FYI, I have re-created the elevatezoom into EZPlus, an up-to-date project at:
https://github.com/igorlino/elevatezoom-plus
Although it has already many build changes, as of today it has nearly the same JS code as KyleMacey' fork (which had the most bug-fixes from all other elevatezoom forks. Thanks for your efforts)
Happy to receive PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants