refactor: default to noImplicitOverride (#42)

Co-authored-by: Richard Herman <[email protected]>
elgatosf · Sep 24, 2024 · 14cb373 · 14cb373
1 parent 641bdfd
commit 14cb373
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/template/src/actions/increment-counter.ts.ejs b/template/src/actions/increment-counter.ts.ejs
@@ -10,7 +10,7 @@ export class IncrementCounter extends SingletonAction<CounterSettings> {
 	 * starting up, or the user navigating between pages / folders etc.. There is also an inverse of this event in the form of {@link streamDeck.client.onWillDisappear}. In this example,
 	 * we're setting the title to the "count" that is incremented in {@link IncrementCounter.onKeyDown}.
 	 */
-	onWillAppear(ev: WillAppearEvent<CounterSettings>): void | Promise<void> {
+	override onWillAppear(ev: WillAppearEvent<CounterSettings>): void | Promise<void> {
 		return ev.action.setTitle(`${ev.payload.settings.count ?? 0}`);
 	}
 
@@ -20,7 +20,7 @@ export class IncrementCounter extends SingletonAction<CounterSettings> {
 	 * and action information where applicable. In this example, our action will display a counter that increments by one each press. We track the current count on the action's persisted
 	 * settings using `setSettings` and `getSettings`.
 	 */
-	async onKeyDown(ev: KeyDownEvent<CounterSettings>): Promise<void> {
+	override async onKeyDown(ev: KeyDownEvent<CounterSettings>): Promise<void> {
 		// Update the count from the settings.
 		const { settings } = ev.payload;
 		settings.incrementBy ??= 1;

diff --git a/template/tsconfig.json.ejs b/template/tsconfig.json.ejs
@@ -5,7 +5,8 @@
 			"node"
 		],
 		"module": "ES2022",
-		"moduleResolution": "Bundler"
+		"moduleResolution": "Bundler",
+		"noImplicitOverride": true
 	},
 	"include": [
 		"src/**/*.ts"