Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default to noImplicitOverride #42

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions template/src/actions/increment-counter.ts.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class IncrementCounter extends SingletonAction<CounterSettings> {
* starting up, or the user navigating between pages / folders etc.. There is also an inverse of this event in the form of {@link streamDeck.client.onWillDisappear}. In this example,
* we're setting the title to the "count" that is incremented in {@link IncrementCounter.onKeyDown}.
*/
onWillAppear(ev: WillAppearEvent<CounterSettings>): void | Promise<void> {
override onWillAppear(ev: WillAppearEvent<CounterSettings>): void | Promise<void> {
return ev.action.setTitle(`${ev.payload.settings.count ?? 0}`);
}

Expand All @@ -20,7 +20,7 @@ export class IncrementCounter extends SingletonAction<CounterSettings> {
* and action information where applicable. In this example, our action will display a counter that increments by one each press. We track the current count on the action's persisted
* settings using `setSettings` and `getSettings`.
*/
async onKeyDown(ev: KeyDownEvent<CounterSettings>): Promise<void> {
override async onKeyDown(ev: KeyDownEvent<CounterSettings>): Promise<void> {
// Update the count from the settings.
const { settings } = ev.payload;
settings.incrementBy ??= 1;
Expand Down
3 changes: 2 additions & 1 deletion template/tsconfig.json.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"node"
],
"module": "ES2022",
"moduleResolution": "Bundler"
"moduleResolution": "Bundler",
"noImplicitOverride": true
},
"include": [
"src/**/*.ts"
Expand Down