-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PKGBUILD and building instructions #217
Conversation
I don't see any problem with this. 🤔
For |
Hmm, I don't know if it's something recently introduced or what, but when I execute a |
Do you have |
This is used for building purposes, so let's enlist it explicitly
1d60b6f
to
f069b46
Compare
I had it installed explicitly with As part of the test I removed the repository completely, cloned it anew, and only did a Btw, if you're okay with the change, what minimal version do you think should be written in |
I wasn't really sure because it doesn't work on my machine (Windows), but I reckon there is something wrong with my settings. 🤔 And again, thank you for the tests and confirmation! 🚀 😁
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for Arch Linux! You rock! 🥳
And thank you for maintaining the package! ❤️ P.S.: if there's any questions/issues about PKGBUILD, feel free to ping me up 👍 |
Fixes: #215
Two points I'm not sure about:
PKGBUILD
to the top dir okay?pkg
not being among deps inpackage.json
an explicit decision, or an omission that needs to be fixed? In the latter case I'd add a commit that fixes this and would remove the explicit installation ofpkg
that is part ofPKGBUILD
and theBuilding from source
sections (in this PR).