Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKGBUILD and building instructions #217

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

Hi-Angel
Copy link
Contributor

Fixes: #215


Two points I'm not sure about:

  1. Is putting PKGBUILD to the top dir okay?
  2. Is pkg not being among deps in package.json an explicit decision, or an omission that needs to be fixed? In the latter case I'd add a commit that fixes this and would remove the explicit installation of pkg that is part of PKGBUILD and the Building from source sections (in this PR).

@jcs090218
Copy link
Member

jcs090218 commented Feb 10, 2024

Is putting PKGBUILD to the top dir okay?

I don't see any problem with this. 🤔

Is pkg not being among deps in package.json an explicit decision, or an omission that needs to be fixed? In the latter case I'd add a commit that fixes this and would remove the explicit installation of pkg that is part of PKGBUILD and the Building from source sections (in this PR).

For pkg, I think you need to install globally (npm i -g pkg) for it to function; hence, pkg isn't in the dependency list.

@Hi-Angel
Copy link
Contributor Author

For pkg, I think you need to install globally (npm i -g pkg) for it to function; hence, pkg isn't in the dependency list

Hmm, I don't know if it's something recently introduced or what, but when I execute a npm -g list | grep pkg there's no output, hence no globally installed pkg. But npm run pkg-linux-x64 still works for me

@jcs090218
Copy link
Member

Hmm, I don't know if it's something recently introduced or what, but when I execute a npm -g list | grep pkg there's no output, hence no globally installed pkg. But npm run pkg-linux-x64 still works for me

Do you have pkg installed in dev dependencies? If it works, then we need to add pkg to dev dependencies. 🤔

@Hi-Angel
Copy link
Contributor Author

Hi-Angel commented Feb 10, 2024

Hmm, I don't know if it's something recently introduced or what, but when I execute a npm -g list | grep pkg there's no output, hence no globally installed pkg. But npm run pkg-linux-x64 still works for me

Do you have pkg installed in dev dependencies? If it works, then we need to add pkg to dev dependencies. 🤔

I had it installed explicitly with npm i pkg, but since you asked I tested adding it to devDependencies (see this commit) and it works for me.

As part of the test I removed the repository completely, cloned it anew, and only did a npm i. Afterwards a npm run pkg-linux-x64 works for me. You can try it 😊

Btw, if you're okay with the change, what minimal version do you think should be written in package.json for pkg? I put a 5.0.0 for the moment since the current version in npm repo is 5.x.x, but it's completely arbitrary.

@jcs090218
Copy link
Member

As part of the test I removed the repository completely, cloned it anew, and only did a npm i. Afterwards a npm run pkg-linux-x64 works for me. You can try it 😊

I wasn't really sure because it doesn't work on my machine (Windows), but I reckon there is something wrong with my settings. 🤔 And again, thank you for the tests and confirmation! 🚀 😁

Btw, if you're okay with the change, what minimal version do you think should be written in package.json for pkg? I put a 5.0.0 for the moment since the current version in npm repo is 5.x.x, but it's completely arbitrary.

^5.0.0 is good. It will default to install the latest version. 👍

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for Arch Linux! You rock! 🥳

@jcs090218 jcs090218 merged commit ffbd53d into emacs-eask:master Feb 10, 2024
151 of 157 checks passed
@Hi-Angel
Copy link
Contributor Author

Hi-Angel commented Feb 10, 2024

And thank you for maintaining the package! ❤️

P.S.: if there's any questions/issues about PKGBUILD, feel free to ping me up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add PKGBUILD to make easier installation on Archlinux (?)
2 participants