fix(pdb): fix PDB can not update

[Rory-Z]

Summary by CodeRabbit

• New Features

  • Enhanced reconciliation process for Pod Disruption Budgets (PDBs) with improved error handling.
  • Dynamic configuration for MinAvailable and MaxUnavailable fields in PDB specifications based on instance specifications.

• Bug Fixes

  • Streamlined PDB creation and update process to reduce errors and improve efficiency.

[coderabbitai]

Walkthrough

The changes in the add_pdb.go file focus on improving the reconciliation logic for Pod Disruption Budgets (PDBs) in the EMQX operator. The implementation has been refactored to use a more consolidated approach for creating and updating PDBs. The new method CreateOrUpdateList replaces the previous individual PDB creation process, simplifying error handling and providing more dynamic configuration of PDB specifications based on instance templates.

Changes

File	Change Summary
controllers/apps/v2beta1/add_pdb.go	- Introduced CreateOrUpdateList method for collective PDB management - Replaced hardcoded PDB values with dynamic values from instance specifications - Simplified error handling and controller reference management

Poem

🐰 Hopping through code with glee and might,
PDBs dancing in a streamlined light
Dynamic configs, errors now tight
EMQX operator's refactored delight
Simplicity wins the coding fight! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

controllers/apps/v2beta1/add_pdb.go (1)

43-44: Centralized error handling is good, but consider logging partial failures.
Centralizing creation and updates of PDBs in one method simplifies the error management. However, consider adding more detailed logging or re-queuing strategies when partial success occurs (e.g., if only one PDB fails to create while others succeed). Doing so may improve debugging and recovery processes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80802a1 and 36a7ba5.

📒 Files selected for processing (1)

• controllers/apps/v2beta1/add_pdb.go (3 hunks)

🔇 Additional comments (2)

controllers/apps/v2beta1/add_pdb.go (2)

104-105: Verify if setting both fields is valid according to your PDB usage.
By specifying both MinAvailable and MaxUnavailable, you risk misconfigurations since typically PDB logic expects either one or the other. Make sure your usage aligns with the official Kubernetes PDB guidelines. Otherwise, consider removing one of the fields or providing a fallback if one is not set.

---

115-116: Confirm replicant PDB consistency with the core PDB.
Similar to the core PDB, both MinAvailable and MaxUnavailable fields are set for the replicant PDB. Validate that the fields match your intended strategy. If not, align the configuration to either use MinAvailable or MaxUnavailable exclusively.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.01%. Comparing base (80802a1) to head (36a7ba5).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/apps/v2beta1/add_pdb.go	0.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   76.19%   76.01%   -0.18%     
==========================================
  Files          69       69              
  Lines        6251     6246       -5     
==========================================
- Hits         4763     4748      -15     
- Misses       1249     1256       +7     
- Partials      239      242       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.