Repository navigation
fix(qt): propagate progress dialog cancellation - #1290
Open
Vamsi-2581 wants to merge 3 commits into
Open
Vamsi-2581 wants to merge 3 commits into
Vamsi-2581 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #135 by making Qt Cancel update the progress dialog's cancellation state before the dialog closes.
Root cause
The Cancel button's
rejectedsignal was connected to the inner Qt dialog'srejectmethod. That closed the dialog without settingProgressDialog._user_cancelled, soupdate()could report success instead of cancellation. The Qt signal also supplies no argument, while the previous handler required one.Changes
rejectedsignal toProgressDialog.reject.QDialogButtonBox.button()looks up standard buttons and cannot retrieve a custom role button.Validation
The Qt GUI tests were not run in this environment. On the current head, GitHub's Qt/wx tests, EDM tests, docs build, and style check are all awaiting maintainer approval; none has produced a job result yet.
AI assistance: OpenAI Codex assisted with the implementation and regression test. Human review and hosted validation remain pending.