config: Update CONNECT-UDP forwarding proxy config #34359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the unnecessary certificates provided in the client context and added SNI field that matches the testing certificate in the repo. Signed-off-by: Jeongseok Son <[email protected]>
|
/assign @danzh2010 Hi Dan, can you review this PR related to #33775? Thank you. |
danzh2010
approved these changes
May 25, 2024
|
/wait |
|
Thanks for reviewing, Dan. Do you have a write access to merge this @danzh2010? Should I ask someone else? |
|
/assign @RyanTheOptimist |
RyanTheOptimist
approved these changes
May 28, 2024
|
I am still seeing error |
It doesn't look like the same problem though, please file a different issue and cc @DavidSchinazi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
I removed the unnecessary certificates provided in the client context and added SNI field that matches the testing certificate in the repo.
Additional Description:
Risk Level: Low, this PR changes an example config.
Testing: N/A
Docs Changes: N/A
Release Notes: N/A