Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Bump the ndk_api_level to 23 #37937

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Jan 8, 2025

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37937 was opened by fredyw.

see: more, trace.

@fredyw fredyw changed the title mobile: Bump the ndk_api_version to 26 mobile: Bump the ndk_api_level to 26 Jan 8, 2025
@fredyw fredyw marked this pull request as ready for review January 8, 2025 19:55
@fredyw
Copy link
Member Author

fredyw commented Jan 8, 2025

/assign @abeyad

abeyad
abeyad previously approved these changes Jan 8, 2025
Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the version that YT is on, out of curiosity?

Signed-off-by: Fredy Wijaya <[email protected]>
@fredyw fredyw changed the title mobile: Bump the ndk_api_level to 26 mobile: Bump the ndk_api_level to 23 Jan 8, 2025
@fredyw
Copy link
Member Author

fredyw commented Jan 8, 2025

is this the version that YT is on, out of curiosity?

I changed it to 23 to match YT.

@phlax
Copy link
Member

phlax commented Jan 8, 2025

I changed it to 23 to match YT.

im unclear what this is setting - only ndk 26 is available - so is this setting something else - ie is the ndk "api level" the same as the "ndk version" ?

@phlax
Copy link
Member

phlax commented Jan 8, 2025

... seems its not - this is why i didnt change it when updating the ndk

chat gpt says of the api level ...

It directly influences the version of Android that the app can run on and what features are available during development.

@fredyw
Copy link
Member Author

fredyw commented Jan 8, 2025

... seems its not - this is why i didnt change it when updating the ndk

chat gpt says of the api level ...

It directly influences the version of Android that the app can run on and what features are available during development.

Yes, the API level is different than the NDK version according to https://android.googlesource.com/platform/ndk/+/master/docs/PlatformApis.md#source-compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants