-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile: Bump the ndk_api_level to 23 #37937
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Fredy Wijaya <[email protected]>
/assign @abeyad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the version that YT is on, out of curiosity?
Signed-off-by: Fredy Wijaya <[email protected]>
I changed it to 23 to match YT. |
im unclear what this is setting - only ndk 26 is available - so is this setting something else - ie is the ndk "api level" the same as the "ndk version" ? |
... seems its not - this is why i didnt change it when updating the ndk chat gpt says of the api level ...
|
Yes, the API level is different than the NDK version according to https://android.googlesource.com/platform/ndk/+/master/docs/PlatformApis.md#source-compatibility |
Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a