execution/state: preserve EIP-8246 balance reads after selfdestruct

[yperbasis]

Fixes #23238.

When a balance-preserving SELFDESTRUCT publishes no BalancePath cell, a later transaction can read zero from an older balance cell while applySubFieldWrites preserves its value. The validator also rejects the preserved nonzero read after the reader is corrected.

Exclude balance cells from both destruct wipe scans. A burning SELFDESTRUCT writes zero explicitly; a preserving one leaves the prior balance intact. Balance version and value checks still detect changed writes.

Add a regression that flushes a real preserving self-destruct write set, verifies the missing balance cell, and checks the later balance against reconstruction, its recorded dependencies, and read-set validation. Update the existing wipe fixtures to use an explicit balance burn or a nonce that SELFDESTRUCT actually clears.

Validation:

• The regression failed with balance 0 instead of 7 before the fix, then failed validation with only the reader fixed, and passes with both changes.
• go test ./execution/state -count=1
• go test -race ./execution/state -count=1
• make lint
• make erigon integration

The regression exercises the state APIs directly. Reachability through a valid EVM transaction remains unverified.

[Copilot]

🔵 Needs a closer look

It changes consensus-critical state-read validation, and valid EVM transaction reachability remains unverified.

Pull request overview

Fixes EIP-8246 balance reads after balance-preserving SELFDESTRUCT.

Changes:

• Excludes preserved balances from destruct wipe scans and validation.
• Adds regression coverage for retained balance cells.
• Updates self-destruct test fixtures.

File summaries

File	Description
execution/state/versionmap.go	Aligns balance validation with preservation semantics.
execution/state/versionmap_test.go	Updates self-destruct validation fixtures.
execution/state/revival_consistency_test.go	Changes the synthetic revival fixture.
execution/state/read_paths.go	Preserves earlier balance cells during reads.
execution/state/eip8246_selfdestruct_test.go	Adds end-to-end state API regression coverage.

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[AskAlexSharov]

Lean already.

[AskAlexSharov]

L589: test: the new balance write at tx 2 makes this fail on the plain version check, so it no longer reaches the SD-staleness branch it is named after. A nonce read, as in the next test, reaches it again.