feat: improve how configures are resolved #26
Conversation
antfu
changed the title
src/configs.ts
Outdated
|
|
||
| const configPath = userConfigPath | ||
| ? resolve(cwd, userConfigPath) | ||
| : await findUp(configFilenames, { cwd: userRootPath || cwd }) |
There was a problem hiding this comment.
Instead of recreating the same logic from ESLint, could you use ESLint#findConfigFile()?
There was a problem hiding this comment.
Since the flat config is just a JS module, I found it's great that you can just import it directly to get the resolved configs - that's what this project was built upon originally. While I pretty much want to share the code, I don't want it to be coupled with users' ESLint version, or specific API that ESLint made public. Right now, the config searching logic isn't complicated; I guess it's ok not to keep it standalone and portable right now. For sure, I am still open to sharing logic if needed in the future.
There was a problem hiding this comment.
Fair enough. My only concern is keeping it in sync if things change, but if we launch from ESLint we can always pass in the specific config file and base path, so maybe not that big of an issue.
| */ | ||
| chdir?: boolean | ||
| } | ||
|
|
||
| export async function readConfig( |
There was a problem hiding this comment.
Can you add some JSDoc for this function so it's easier to understand what exactly is being passed in?
fix #25
find-up, aligning with ESLint