-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Cenk Alti <[email protected]>
- Loading branch information
Showing
7 changed files
with
295 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package snapshot | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "path/filepath" | ||
| "strconv" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/zap" | ||
|
|
||
| "go.etcd.io/bbolt" | ||
| "go.etcd.io/etcd/api/v3/etcdserverpb" | ||
| "go.etcd.io/etcd/server/v3/embed" | ||
| "go.etcd.io/etcd/server/v3/etcdserver" | ||
| "go.etcd.io/etcd/server/v3/storage/mvcc" | ||
| ) | ||
|
|
||
| // TestSnapshotStatus is the happy case. | ||
| // It inserts pre-defined number of keys and asserts the output hash of status command. | ||
| // The expected hash value must not be changed. | ||
| // If it changes, there must be some backwards incompatible change introduced. | ||
| func TestSnapshotStatus(t *testing.T) { | ||
| dbpath := createDB(t, insertKeys(t, 10, 100)) | ||
|
|
||
| status, err := NewV3(zap.NewNop()).Status(dbpath) | ||
| require.NoError(t, err) | ||
|
|
||
| assert.Equal(t, uint32(0x62132b4d), status.Hash) | ||
| assert.Equal(t, int64(11), status.Revision) | ||
| } | ||
|
|
||
| // TestSnapshotStatusCorruptRevision tests if snapshot status command fails when there is an unexpected revision in "key" bucket. | ||
| func TestSnapshotStatusCorruptRevision(t *testing.T) { | ||
| dbpath := createDB(t, insertKeys(t, 1, 0)) | ||
|
|
||
| db, err := bbolt.Open(dbpath, 0666, nil) | ||
| require.NoError(t, err) | ||
| defer db.Close() | ||
|
|
||
| err = db.Update(func(tx *bbolt.Tx) error { | ||
| b := tx.Bucket([]byte("key")) | ||
| if b == nil { | ||
| return errors.New("key bucket not found") | ||
| } | ||
| return b.Put([]byte("0"), []byte{}) | ||
| }) | ||
| require.NoError(t, err) | ||
| db.Close() | ||
|
|
||
| _, err = NewV3(zap.NewNop()).Status(dbpath) | ||
| require.Error(t, err) | ||
| } | ||
|
|
||
| // TestSnapshotStatusNegativeRevisionMain tests if snapshot status command fails when main revision number is negative. | ||
| func TestSnapshotStatusNegativeRevisionMain(t *testing.T) { | ||
| dbpath := createDB(t, insertKeys(t, 1, 0)) | ||
|
|
||
| db, err := bbolt.Open(dbpath, 0666, nil) | ||
| require.NoError(t, err) | ||
| defer db.Close() | ||
|
|
||
| err = db.Update(func(tx *bbolt.Tx) error { | ||
| b := tx.Bucket([]byte("key")) | ||
| if b == nil { | ||
| return errors.New("key bucket not found") | ||
| } | ||
| bytes := make([]byte, 17) // 2 int64 and a separator | ||
| mvcc.RevToBytes(mvcc.Revision{Main: -2}, bytes) // -1 is allowed for main rev | ||
| return b.Put(bytes, []byte{}) | ||
| }) | ||
| require.NoError(t, err) | ||
| db.Close() | ||
|
|
||
| _, err = NewV3(zap.NewNop()).Status(dbpath) | ||
| require.Error(t, err) | ||
| } | ||
|
|
||
| // TestSnapshotStatusNegativeRevisionSub tests if snapshot status command fails when sub revision number is negative. | ||
| func TestSnapshotStatusNegativeRevisionSub(t *testing.T) { | ||
| dbpath := createDB(t, insertKeys(t, 1, 0)) | ||
|
|
||
| db, err := bbolt.Open(dbpath, 0666, nil) | ||
| require.NoError(t, err) | ||
| defer db.Close() | ||
|
|
||
| err = db.Update(func(tx *bbolt.Tx) error { | ||
| b := tx.Bucket([]byte("key")) | ||
| if b == nil { | ||
| return errors.New("key bucket not found") | ||
| } | ||
| bytes := make([]byte, 17) // 2 int64 and a separator | ||
| mvcc.RevToBytes(mvcc.Revision{Sub: -1}, bytes) | ||
| return b.Put(bytes, []byte{}) | ||
| }) | ||
| require.NoError(t, err) | ||
| db.Close() | ||
|
|
||
| _, err = NewV3(zap.NewNop()).Status(dbpath) | ||
| require.Error(t, err) | ||
| } | ||
|
|
||
| // insertKeys insert `numKeys` number of keys of `valueSize` size into a running etcd server. | ||
| func insertKeys(t *testing.T, numKeys, valueSize int) func(*etcdserver.EtcdServer) { | ||
| t.Helper() | ||
| return func(srv *etcdserver.EtcdServer) { | ||
| val := make([]byte, valueSize) | ||
| for i := 0; i < numKeys; i++ { | ||
| req := etcdserverpb.PutRequest{ | ||
| Key: []byte(strconv.Itoa(i)), | ||
| Value: val, | ||
| } | ||
| _, err := srv.Put(context.TODO(), &req) | ||
| require.NoError(t, err) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // createDB creates a bbolt database file by running an embedded etcd server. | ||
| // While the server is running, `generateContent` function is called to insert values. | ||
| // It returns the path of bbolt database. | ||
| func createDB(t *testing.T, generateContent func(*etcdserver.EtcdServer)) string { | ||
| t.Helper() | ||
|
|
||
| cfg := embed.NewConfig() | ||
| cfg.LogLevel = "fatal" | ||
| cfg.Dir = t.TempDir() | ||
|
|
||
| etcd, err := embed.StartEtcd(cfg) | ||
| require.NoError(t, err) | ||
| defer etcd.Close() | ||
|
|
||
| select { | ||
| case <-etcd.Server.ReadyNotify(): | ||
| case <-time.After(10 * time.Second): | ||
| t.FailNow() | ||
| } | ||
|
|
||
| generateContent(etcd.Server) | ||
|
|
||
| return filepath.Join(cfg.Dir, "member", "snap", "db") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters