Skip to content

[release-3.5] fileutil: close locked file handle on os.Remove error in purgeFile - #22457

Open
k8s-infra-cherrypick-robot wants to merge 1 commit into
etcd-io:release-3.5from
k8s-infra-cherrypick-robot:cherry-pick-22452-to-release-3.5
Open

k8s-infra-cherrypick-robot wants to merge 1 commit into
etcd-io:release-3.5from
k8s-infra-cherrypick-robot:cherry-pick-22452-to-release-3.5

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #22452

/assign ahrtr

Close the locked file when os.Remove fails. Log any close error while
preserving the original removal error returned to the caller.

Signed-off-by: Todd Hendricks <tjhendrx@icloud.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr

ahrtr commented Sep 20, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@ahrtr

ahrtr commented Sep 20, 2026

Copy link
Copy Markdown
Member

/retest

@kubernetes-prow

kubernetes-prow Bot commented Sep 20, 2026

Copy link
Copy Markdown

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-govulncheck 1b0a379 link true /test pull-etcd-govulncheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants