Check lastPreimage != nil before accessing the cached preimage #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Fast VM implementation assumes the last preimage read has been cached, even if this is the first read. Moreover, the preimage key is always initialized to zeroes ([32]byte{}) while the cached preimage value is initialized to a null pointer.
That means if either there's an attempt to read the preimage value before writing a key, or if the key written is zero, an attempt to access the null pointer will cause a panic.
Neither scenario should happen in a correct Kona implementation -- reads should always be preceded by writing the corresponding key, and a key with zero value isn't valid. However this is the oracle's concern and should be delegated to it.